Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Flask-OpenID to 1.3.0 #16648

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Sep 9, 2021

SUMMARY

setuptools release 58.0.2 removed use_2to3 and that broke Flask-OpenID that is a dependency on Flask-AppBuilder.
This caused Apache Superset installations with setuptools >= 58.0.2 to fail with:

error in Flask-OpenID setup command: use_2to3 is invalid.

Latest Flask-OpenID 1.3.0 removed use_2to3 dependency and updated the code to python3.

More details here: pallets-eco/flask-openid#59

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #16648 (a27dedc) into master (6465ee7) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16648      +/-   ##
==========================================
- Coverage   76.70%   76.56%   -0.15%     
==========================================
  Files        1004     1004              
  Lines       53983    53983              
  Branches     7335     7335              
==========================================
- Hits        41408    41331      -77     
- Misses      12336    12413      +77     
  Partials      239      239              
Flag Coverage Δ
hive ?
mysql 81.59% <ø> (ø)
postgres 81.62% <ø> (+<0.01%) ⬆️
python 81.70% <ø> (-0.28%) ⬇️
sqlite 81.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-1.05%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 88.04% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.76% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6465ee7...a27dedc. Read the comment docs.

@villebro villebro added the v1.3 label Sep 9, 2021
@dpgaspar dpgaspar merged commit 3d0ebd5 into apache:master Sep 9, 2021
@dpgaspar dpgaspar deleted the chore/bump-flaskopenid branch September 9, 2021 13:09
villebro pushed a commit that referenced this pull request Sep 22, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v1.3 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants