Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix assignment in FilterBoxViz #16662

Merged
merged 5 commits into from
Sep 10, 2021

Conversation

tianhe1986
Copy link
Contributor

SUMMARY

Just a small fix, assigning to the right object.
Or, it will throw TypeError: 'NoneType' object does not support item assignment when df is None.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
@villebro villebro added the v1.3 label Sep 10, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the fix!

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #16662 (b2ad3f0) into master (6465ee7) will increase coverage by 0.07%.
The diff coverage is 83.82%.

❗ Current head b2ad3f0 differs from pull request most recent head c772fd5. Consider uploading reports for the commit c772fd5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16662      +/-   ##
==========================================
+ Coverage   76.70%   76.78%   +0.07%     
==========================================
  Files        1004     1005       +1     
  Lines       53983    54005      +22     
  Branches     7335     7337       +2     
==========================================
+ Hits        41408    41467      +59     
+ Misses      12336    12298      -38     
- Partials      239      240       +1     
Flag Coverage Δ
hive ?
mysql 81.65% <81.81%> (+0.06%) ⬆️
postgres 81.68% <81.81%> (+0.06%) ⬆️
presto 81.52% <81.81%> (?)
python 81.94% <81.81%> (-0.04%) ⬇️
sqlite 81.33% <81.81%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/nativeFilters/FiltersConfigModal/utils.ts 72.22% <ø> (-1.39%) ⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts 56.25% <ø> (ø)
superset/sql_lab.py 80.70% <ø> (ø)
superset/views/core.py 76.00% <81.48%> (+0.37%) ⬆️
superset-frontend/src/components/Select/Select.tsx 89.95% <88.88%> (+17.30%) ⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 73.20% <100.00%> (+0.07%) ⬆️
...nd/src/dashboard/components/nativeFilters/types.ts 100.00% <100.00%> (ø)
superset/viz.py 57.42% <100.00%> (+0.79%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6465ee7...c772fd5. Read the comment docs.

@villebro villebro merged commit bb014b5 into apache:master Sep 10, 2021
villebro pushed a commit that referenced this pull request Sep 22, 2021
* Fixing assignment.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Adding unit test for FilterBoxViz.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with black.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Revert format change in other test.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with the same black version with pre-commit config.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>
(cherry picked from commit bb014b5)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* Fixing assignment.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Adding unit test for FilterBoxViz.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with black.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Revert format change in other test.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with the same black version with pre-commit config.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* Fixing assignment.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Adding unit test for FilterBoxViz.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with black.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Revert format change in other test.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with the same black version with pre-commit config.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>
@mistercrunch mistercrunch added 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v1.3 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants