-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix assignment in FilterBoxViz #16662
Conversation
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for the fix!
Codecov Report
@@ Coverage Diff @@
## master #16662 +/- ##
==========================================
+ Coverage 76.70% 76.78% +0.07%
==========================================
Files 1004 1005 +1
Lines 53983 54005 +22
Branches 7335 7337 +2
==========================================
+ Hits 41408 41467 +59
+ Misses 12336 12298 -38
- Partials 239 240 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Fixing assignment. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Adding unit test for FilterBoxViz. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with black. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Revert format change in other test. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with the same black version with pre-commit config. Signed-off-by: tianhe1986 <w1s2j3229@163.com> (cherry picked from commit bb014b5)
* Fixing assignment. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Adding unit test for FilterBoxViz. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with black. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Revert format change in other test. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with the same black version with pre-commit config. Signed-off-by: tianhe1986 <w1s2j3229@163.com>
* Fixing assignment. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Adding unit test for FilterBoxViz. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with black. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Revert format change in other test. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with the same black version with pre-commit config. Signed-off-by: tianhe1986 <w1s2j3229@163.com>
SUMMARY
Just a small fix, assigning to the right object.
Or, it will throw
TypeError: 'NoneType' object does not support item assignment
whendf
is None.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION