refactor: sql_json view endpoint: use execution context instead of query #16677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16677 +/- ##
==========================================
+ Coverage 76.91% 76.93% +0.01%
==========================================
Files 1005 1005
Lines 54017 54044 +27
Branches 7337 7337
==========================================
+ Hits 41549 41577 +28
+ Misses 12228 12227 -1
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…ery (apache#16677) * refactor sql_json view endpoint: use execution context instead of query * fix failed tests * fix failed tests * refactor renaming enum options
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…ery (apache#16677) * refactor sql_json view endpoint: use execution context instead of query * fix failed tests * fix failed tests * refactor renaming enum options
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the twelveth PR in the sequence of future PRs (previous PR) try to solve it by refactoring the code.
The PR focus on start using execution context to create the final response and get an execution status from the private method who will be refactored soon to a Command class
This is the second PR who build the basis so the code will be able to be separated into layers
there are no logic changes so it implies on the current tests.