fix: don't send invalid URLs back to the user #16687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
Sep 13, 2021
dpgaspar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #16687 +/- ##
==========================================
- Coverage 76.93% 76.85% -0.08%
==========================================
Files 1005 1005
Lines 54049 54056 +7
Branches 7339 7339
==========================================
- Hits 41581 41547 -34
- Misses 12228 12269 +41
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
craig-rueda
approved these changes
Sep 14, 2021
dpgaspar
deleted the
danielgaspar/ch25032/prevent-sending-url-back-to-the-user-on-the
branch
villebro
pushed a commit
that referenced
this pull request
Sep 22, 2021
* fix: don't send bogus URLs back to the user * lint, remove f string (cherry picked from commit 5ac8ac0)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: don't send bogus URLs back to the user * lint, remove f string
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix: don't send bogus URLs back to the user * lint, remove f string
mistercrunch
added
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Avoid sending a bogus URL back to the user, these can apparently cause a reflect XSS issue, yet the only possible victim is the attacker himself.
ADDITIONAL INFORMATION