Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add semantic title to the pull request template #16693

Merged
merged 1 commit into from Sep 17, 2021

Conversation

suddjian
Copy link
Member

SUMMARY

So people know to do it before CI tells them

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #16693 (4ec04a8) into master (1669947) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16693      +/-   ##
==========================================
+ Coverage   76.86%   76.93%   +0.07%     
==========================================
  Files        1007     1007              
  Lines       54108    54108              
  Branches     7344     7344              
==========================================
+ Hits        41588    41629      +41     
+ Misses      12280    12239      -41     
  Partials      240      240              
Flag Coverage Δ
hive 81.30% <ø> (ø)
javascript 71.26% <ø> (ø)
mysql 81.68% <ø> (ø)
postgres 81.70% <ø> (-0.04%) ⬇️
presto 81.54% <ø> (?)
python 82.25% <ø> (+0.14%) ⬆️
sqlite 81.31% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 89.40% <0.00%> (+0.25%) ⬆️
superset/connectors/sqla/models.py 89.70% <0.00%> (+1.42%) ⬆️
superset/db_engine_specs/presto.py 90.37% <0.00%> (+5.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1669947...4ec04a8. Read the comment docs.

@junlincc junlincc added the need:merge The PR is ready to be merged label Sep 15, 2021
@etr2460
Copy link
Member

etr2460 commented Sep 17, 2021

Thanks for adding this!

@zhaoyongjie zhaoyongjie merged commit a4f6001 into master Sep 17, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@trixieboyle
Copy link

#Tammy Boyle Codecov Report

Merging #16693 (4ec04a8) into master (1669947) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16693      +/-   ##
==========================================
+ Coverage   76.86%   76.93%   +0.07%     
==========================================
  Files        1007     1007              
  Lines       54108    54108              
  Branches     7344     7344              
==========================================
+ Hits        41588    41629      +41     
+ Misses      12280    12239      -41     
  Partials      240      240              
Flag Coverage Δ
hive 81.30% <ø> (ø)
javascript 71.26% <ø> (ø)
mysql 81.68% <ø> (ø)
postgres 81.70% <ø> (-0.04%) ⬇️
presto 81.54% <ø> (?)
python 82.25% <ø> (+0.14%) ⬆️
sqlite 81.31% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 89.40% <0.00%> (+0.25%) ⬆️
superset/connectors/sqla/models.py 89.70% <0.00%> (+1.42%) ⬆️
superset/db_engine_specs/presto.py 90.37% <0.00%> (+5.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1669947...4ec04a8. Read the comment docs.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the pr-template-semantic-title branch March 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset-io size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants