Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignores case and special keys when searching in the Select component #16706

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Sep 14, 2021

SUMMARY

  • Ignores case and special keys when searching in the Select component.
  • Adds tests for the fixes.

TESTING INSTRUCTIONS

All tests should pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title fix: Ignores the case and special keys when searching fix: Ignores case and special keys when searching the Select component Sep 14, 2021
@michael-s-molina michael-s-molina changed the title fix: Ignores case and special keys when searching the Select component fix: Ignores case and special keys when searching in the Select component Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #16706 (faa0fac) into master (9f5f679) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16706   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files        1007     1007           
  Lines       54146    54139    -7     
  Branches     7367     7366    -1     
=======================================
- Hits        41668    41665    -3     
+ Misses      12238    12234    -4     
  Partials      240      240           
Flag Coverage Δ
javascript 71.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 91.76% <100.00%> (+0.09%) ⬆️
superset-frontend/src/setup/setupColors.ts 100.00% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5f679...faa0fac. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit adc3d24 into apache:master Sep 15, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants