Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade immer package version #16741

Merged
merged 21 commits into from
Sep 20, 2021
Merged

chore: Upgrade immer package version #16741

merged 21 commits into from
Sep 20, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Sep 19, 2021

We update major version of immer to keep the dependency up to date

Tested in:

  • Native Filters area
  • Filters Sets area

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 changed the title chore: Upgrade immer version chore: Upgrade immer package version Sep 19, 2021
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #16741 (a41408b) into master (67b1330) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16741   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files        1007     1007           
  Lines       54174    54174           
  Branches     7463     7463           
=======================================
  Hits        41708    41708           
  Misses      12226    12226           
  Partials      240      240           
Flag Coverage Δ
javascript 71.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b1330...a41408b. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the bump!

@simcha90 simcha90 merged commit 985aa06 into apache:master Sep 20, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* fix:fix get permission function

* chore: update immer

* chore: update immer
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* fix:fix get permission function

* chore: update immer

* chore: update immer
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants