fix: only fetch db function when db exists in sql lab #16754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16754 +/- ##
==========================================
- Coverage 76.98% 76.98% -0.01%
==========================================
Files 1007 1007
Lines 54174 54175 +1
Branches 7463 7464 +1
==========================================
- Hits 41708 41704 -4
- Misses 12226 12231 +5
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Sep 21, 2021
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://54.213.51.202:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
|
🏷 2021.38 |
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 22, 2021
(cherry picked from commit d375538)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When closing multiple tabs, there would sometimes be errors because we were fetching function names with a null db. This checks that the db is present before updating. If the db is not present, the function names will fetch on the left toolbar db change method.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
CleanShot.2021-06-24.at.11.14.59.mov
TESTING INSTRUCTIONS
save a query, copy it and open it in a window. Open a bunch of saved queries so that you have about 4 tabs loading all at once on a page load, then close them one by one. There should be no errors, and your database should update.
ADDITIONAL INFORMATION