fix(helm): Exit init script immediately on error #16758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds
set -eu
to the init script. With this the script will exit immediately when it encounters an error or an unset variable.TESTING INSTRUCTIONS
In order to test that this works you will need a k8s environment. One way to test this is to manually add an error into the init script by including an invalid command (just make sure that the last command in the script is still a working command). Then start a helm deployment. Without this PR the init job will be marked as success despite the error. With this PR applied the init job will be marked as failed.
ADDITIONAL INFORMATION
ADDITIONAL THOUGHTS
I personally think failing when an error occurs should be the default behavior. However, I could see that some people might prefer it if the script does not fail and instead tries the remaining init steps. If this is wanted I could add a flag to the init config in
values.yaml
so that users can easily select the behavior they want. Let me know if this is wanted or if this PR is ok as it is. I personally don't really think it's worth including a switch, because with the current behavior you would need to read the whole init job logs in order to know if there were any problems.