Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bulk update Spanish translations #16799

Merged
merged 8 commits into from Nov 23, 2021
Merged

Conversation

dreglad
Copy link
Contributor

@dreglad dreglad commented Sep 22, 2021

fix(translation): Update Spanish translations

SUMMARY

Spanish translations were largely updated including many of them that were dangerously inaccurate or incorrect, such like translating "delete" as indeed the opposite "create" which obviously would be catastrophic in many situations.

TESTING INSTRUCTIONS

The Spanish language has many linguistic variants depending on factors such as geographic region. These translations aim to be as neutral as possible. It might be still far from perfect, however there were largely incomplete and many of them severely inaccurate (even translating to the exact opposite meaning!)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #16799 (0f10e1d) into master (bc855f4) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16799      +/-   ##
==========================================
- Coverage   76.92%   76.78%   -0.14%     
==========================================
  Files        1048     1048              
  Lines       56514    56514              
  Branches     7805     7805              
==========================================
- Hits        43474    43397      -77     
- Misses      12786    12863      +77     
  Partials      254      254              
Flag Coverage Δ
hive ?
mysql 81.99% <ø> (ø)
postgres 82.00% <ø> (ø)
python 82.09% <ø> (-0.27%) ⬇️
sqlite 81.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-0.84%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 86.79% <0.00%> (-0.23%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc855f4...0f10e1d. Read the comment docs.

@dreglad dreglad changed the title Bulk update Spanish translations fix: Bulk update Spanish translations Sep 26, 2021
Copy link
Contributor

@diegomgomez diegomgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped a bunch of comments for the first 1/3 or so of the file. Mostly nits or small syntax/grammar corrections

superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
superset/translations/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
Copy link
Contributor

@diegomgomez diegomgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass for the rest of the file. Many nits, grammar, spelling, and syntax fixes. Hope this helps!


#: superset/views/database/forms.py:130 superset/views/database/forms.py:321
msgid "Table Exists"
msgstr ""
msgstr "Tabla Existe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Tabla Existe"
msgstr "La Tabla Existe"

@@ -2879,19 +2885,19 @@ msgstr ""

#: superset/views/database/forms.py:137 superset/views/database/forms.py:328
msgid "Fail"
msgstr ""
msgstr "Falla"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Falla"
msgstr "Fallido"


#: superset/views/database/forms.py:138 superset/views/database/forms.py:329
msgid "Replace"
msgstr ""
msgstr "Remplazar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Remplazar"
msgstr "Reemplazar"

@@ -2911,79 +2917,79 @@ msgstr ""

#: superset/views/database/forms.py:163 superset/views/database/forms.py:354
msgid "Mangle Duplicate Columns"
msgstr ""
msgstr "Manglar Columnas Duplicadas"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky - AFAIK there's nothing such as mangling in Spanish (a "manglar" is a mango tree orchard lol). The closest one I can think of reads as "Decorate name for duplicated values".

Suggested change
msgstr "Manglar Columnas Duplicadas"
msgstr "Decorar Nombre de Columnas Duplicadas"


#: superset/views/database/forms.py:182
msgid "Skip Blank Lines"
msgstr ""
msgstr "Saltar líneas vacías"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Saltar líneas vacías"
msgstr "Omitir líneas vacías"


#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:83
msgid "Check to include time column dropdown"
msgstr "Mostrar un filtro de tiempo"
msgstr "Marcar para incluir la columna de tiempo en la caja de selección"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Marcar para incluir la columna de tiempo en la caja de selección"
msgstr "Marcar para incluir la lista desplegable de tiempo de la columna"


#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:92
msgid "Show Druid granularity dropdown"
msgstr ""
msgstr "Mostrar caja de selección de Granularidad de Druid"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Mostrar caja de selección de Granularidad de Druid"
msgstr "Mostrar lista desplegable de granularidad de Druid"


#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:94
msgid "Check to include Druid granularity dropdown"
msgstr ""
msgstr "Marcar para incluir la caja de selección de Granularidad de Druid"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Marcar para incluir la caja de selección de Granularidad de Druid"
msgstr "Marcar para incluir la lista desplegable de granularidad de Druid"


#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:103
msgid "Check to include time origin dropdown"
msgstr "Mostrar un filtro de tiempo"
msgstr "Marcar para incluir la caja de selección de origen de tiempo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Marcar para incluir la caja de selección de origen de tiempo"
msgstr "Marcar para incluir la lista desplegable de origen de tiempo"


#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:114
msgid "These filters apply to the values available in the dropdowns"
msgstr ""
msgstr "Estos filtros aplican para los valores disponibles en la caja de selección"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Estos filtros aplican para los valores disponibles en la caja de selección"
msgstr "Estos filtros son aplicados a los valores disponibles en la lista desplegable"

@dreglad
Copy link
Contributor Author

dreglad commented Oct 4, 2021

Second pass for the rest of the file. Many nits, grammar, spelling, and syntax fixes. Hope this helps!

Thanks @diegomgomez! It seems that the file diff is too large to load and I can't bulk add your suggestions from within Github. Can you create a commit including all your suggestions? I added you as collaborator to my fork, so you won't need to create your own.

@diegomgomez
Copy link
Contributor

Thanks @diegomgomez! It seems that the file diff is too large to load and I can't bulk add your suggestions from within Github. Can you create a commit including all your suggestions? I added you as collaborator to my fork, so you won't need to create your own.

No, sorry. It's a burden that Github apparently doesn't allow you to bulk accept suggestions, but at this point it'd be too much (and repated) work for me to create a branch and re-make all the changes than to accept them from the current branch. It'd also be advisable that you take a quick look over my changes to make sure you agree with them, which should blend in with the suggestion acceptance process.

@villebro
Copy link
Member

Thanks @dreglad and @diegomgomez for the hard work here! This PR is in a conflicted state; can you please rebase it so we can get it merged? If you both agree this PR leaves the translation in a better state than before, I'm happy to merge this and welcome incremental improvements in follow-up PRs.

@villebro
Copy link
Member

@dreglad if needed I can rebase the PR, but since I don't speak Spanish I may introduce errors in the translations, hence it may be better if one you could help push this across the finish line

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the hard work!

@villebro villebro merged commit 0f3b630 into apache:master Nov 23, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* Bulk update Spanish translations

* Update Spanish translations

* Apply Spanish translations suggestions from code review

Co-authored-by: Diego M. Gómez <diegomgomez@gmail.com>

* convert json file

Co-authored-by: Diego M. Gómez <diegomgomez@gmail.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants