Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump superset to 0.18.6 #16807

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 23, 2021

SUMMARY

Pull in the following PRs from superset-ui:

This PR also removes the direct dependency on math-expression-evaluator, as it's now a dependency in superset-ui/core that exposes the relevant functionality along with full test coverage.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create a formula annotation using both NVD3 and ECharts timeseries charts
  2. Notice that formulas render like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #16807 (f8278d2) into master (997320a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16807      +/-   ##
==========================================
- Coverage   76.89%   76.89%   -0.01%     
==========================================
  Files        1005     1005              
  Lines       54169    54163       -6     
  Branches     7456     7454       -2     
==========================================
- Hits        41653    41648       -5     
+ Misses      12272    12271       -1     
  Partials      244      244              
Flag Coverage Δ
javascript 71.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 83.85% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997320a...f8278d2. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 4086bed into apache:master Sep 23, 2021
@villebro villebro deleted the villebro/bump-0.18.6 branch September 23, 2021 12:00
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants