Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 500 tab title #16836

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix: 500 tab title #16836

merged 1 commit into from
Sep 24, 2021

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Sep 24, 2021

SUMMARY

As titled

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @michael-s-molina

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #16836 (52b1faa) into master (0d064f4) will not change coverage.
The diff coverage is n/a.

❗ Current head 52b1faa differs from pull request most recent head d998333. Consider uploading reports for the commit d998333 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16836   +/-   ##
=======================================
  Coverage   76.99%   76.99%           
=======================================
  Files        1018     1018           
  Lines       54674    54674           
  Branches     7456     7456           
=======================================
  Hits        42094    42094           
  Misses      12335    12335           
  Partials      245      245           
Flag Coverage Δ
javascript 71.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d064f4...d998333. Read the comment docs.

@etr2460 etr2460 merged commit 55e2872 into master Sep 24, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the etr2460-patch-3 branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants