refactor: sql lab: handling command exceptions #16852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the exception to dictionary
…the exception to dictionary
…ry was not created
ofekisr
force-pushed
the
refactor/sql_lab2
branch
from
bf5bd14
to
2d4bddb
Compare
Codecov Report
@@ Coverage Diff @@
## master #16852 +/- ##
==========================================
+ Coverage 76.79% 76.90% +0.10%
==========================================
Files 1021 1022 +1
Lines 54707 54836 +129
Branches 7457 7470 +13
==========================================
+ Hits 42014 42172 +158
+ Misses 12449 12418 -31
- Partials 244 246 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* chore: support error_type in SupersetException and method to convert the exception to dictionary * chore: support error_type in SupersetException and method to convert the exception to dictionary * refactor handling command exceptions fix update query status when query was not created
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* chore: support error_type in SupersetException and method to convert the exception to dictionary * chore: support error_type in SupersetException and method to convert the exception to dictionary * refactor handling command exceptions fix update query status when query was not created
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the fifteenth PR in the sequence of future PRs ([previous PR](refactor: sql_json view endpoint: move all logic from view to Command class)) try to solve it by refactoring the code.
The PR focus on organizing the command exception handling
actually, there are no logic changes so it implies on the current tests.