Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(native_filter): feature on by default #16874

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

junlincc
Copy link
Member

@junlincc junlincc commented Sep 28, 2021

SUMMARY

This PR is making Dashboard Native_Filter on by default. User will be able to access to this feature without configuring going forward. This feature has been throughout tested and is ready for prime time. In fact, without this feature being visible, user may hit bugs when trying to use the legacy Filterbox along or with Native filter at the same time. This change will also drive users away from using Filterbox which has been causing errors.

NOTE: We will remove this FF for good in about 1 month.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-09-28 at 10 13 05 AM

### TESTING INSTRUCTIONS NA

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • [x ] Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #16874 (7b5a920) into master (b35645c) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 7b5a920 differs from pull request most recent head 461a101. Consider uploading reports for the commit 461a101 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16874      +/-   ##
==========================================
- Coverage   77.05%   76.90%   -0.15%     
==========================================
  Files        1021     1021              
  Lines       54693    54693              
  Branches     7457     7457              
==========================================
- Hits        42141    42059      -82     
- Misses      12307    12389      +82     
  Partials      245      245              
Flag Coverage Δ
hive ?
mysql 81.80% <ø> (-0.04%) ⬇️
postgres ?
presto 81.74% <ø> (-0.01%) ⬇️
python 82.12% <ø> (-0.29%) ⬇️
sqlite 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.44% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/postgres.py 96.49% <0.00%> (-0.88%) ⬇️
superset/views/base_api.py 97.89% <0.00%> (-0.43%) ⬇️
superset/db_engine_specs/presto.py 89.95% <0.00%> (-0.42%) ⬇️
superset/connectors/sqla/models.py 87.01% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.84% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b35645c...461a101. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - rerunning tests to see if it's just flakiness or if some tests need updating

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this!

@amitmiran137 amitmiran137 merged commit f0060a6 into master Oct 2, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the turn-on-native-filter-by-default branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants