chore: Moves the stylesheets folder to the assets folder #16880
Conversation
superset-frontend/package.json
Outdated
| "prettier-check": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}'", | ||
| "prettier-check": "prettier --check '{src}/**/*.{css,less,sass,scss}'", | ||
| "lint-fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx . && npm run clean-css && npm run type", | ||
| "clean-css": "prettier --write '{src,stylesheets}/**/*.{css,less,sass,scss}'", | ||
| "format": "prettier --write './{src,spec,stylesheets,cypress-base}/**/*{.js,.jsx,.ts,.tsx,.css,.less,.scss,.sass}'", | ||
| "clean-css": "prettier --write '{src}/**/*.{css,less,sass,scss}'", | ||
| "format": "prettier --write './{src,spec,cypress-base}/**/*{.js,.jsx,.ts,.tsx,.css,.less,.scss,.sass}'", |
There was a problem hiding this comment.
The cases with '{src}/**/...' would probably look nicer as just 'src/**/...'
There was a problem hiding this comment.
That was the thing making the linter fail. I changed to your suggestion.
Codecov Report
@@ Coverage Diff @@
## master #16880 +/- ##
==========================================
- Coverage 77.05% 76.97% -0.08%
==========================================
Files 1021 1022 +1
Lines 54693 54756 +63
Branches 7457 7472 +15
==========================================
+ Hits 42141 42147 +6
- Misses 12307 12361 +54
- Partials 245 248 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@pkdotson Ephemeral environment spinning up at http://34.211.223.9:8080. Credentials are |
|
I have tested in the ephemeral environment and i saw one issue: When i run query in sql, i did not see 'EXPLORE' option under results tab and did not see this issue in master, not sure whether is this PR related. Can you check that?
|
|
@jinghua-qa Thanks for testing! I was able to reproduce the same problem on master so it's not related to this PR. I checked and it's not related to the stylesheets. I took note here and I will fix the problem in another PR. |
|
@jinghua-qa The problem with the Explore button was fixed here #16908 |
|
Ephemeral environment shutdown and build artifacts deleted. |
* chore: Moves the stylesheets folder to the assets folder
* Changes {src} to src
* chore: Moves the stylesheets folder to the assets folder
* Changes {src} to src
mistercrunch
added
🏷️ bot
SUMMARY
Moves the
stylesheetsfolder to theassetsfolder.This work is part of SIP-61
@jinghua-qa @junlincc
TESTING INSTRUCTIONS
1 - Navigate through the application
2 - Check that all styles are loaded correctly
ADDITIONAL INFORMATION