Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace absolute difference with difference in compareOperator #16930

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Oct 1, 2021

SUMMARY

Currently, incorrect type of calculation in time comparsion, should replace absolute difference with difference

frontend codes at: apache-superset/superset-ui#1383

closes: #16766

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Absolute value diff is incorrect #16766
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #16930 (c38e843) into master (87baac7) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head c38e843 differs from pull request most recent head f069f30. Consider uploading reports for the commit f069f30 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16930      +/-   ##
==========================================
- Coverage   76.97%   76.89%   -0.09%     
==========================================
  Files        1022     1022              
  Lines       54903    54903              
  Branches     7485     7485              
==========================================
- Hits        42262    42218      -44     
- Misses      12393    12437      +44     
  Partials      248      248              
Flag Coverage Δ
hive 81.45% <100.00%> (ø)
mysql 81.85% <100.00%> (ø)
postgres 81.91% <100.00%> (ø)
presto ?
python 82.26% <100.00%> (-0.16%) ⬇️
sqlite 81.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/constants.py 100.00% <100.00%> (ø)
superset/utils/pandas_postprocessing.py 84.42% <100.00%> (ø)
superset/db_engine_specs/presto.py 84.30% <0.00%> (-6.07%) ⬇️
superset/connectors/sqla/models.py 85.83% <0.00%> (-1.42%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87baac7...f069f30. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we can get a fast-follow with a migration!

@zhaoyongjie zhaoyongjie merged commit 387ac2b into apache:master Oct 4, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
…pache#16930)

* fix: replace absolute difference with difference in compareOperator

* fix ut
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
…pache#16930)

* fix: replace absolute difference with difference in compareOperator

* fix ut
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute value diff is incorrect
3 participants