fix(build): make npm linking work pt. 2 #16958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
reviewed
Oct 4, 2021
| @@ -289,9 +289,10 @@ const config = { | |||
| APP_DIR, | |||
| './node_modules/@superset-ui/chart-controls', | |||
| ), | |||
| react: path.resolve('./node_modules/react'), | |||
There was a problem hiding this comment.
Perhaps we should have react as peer dep in superset-ui then?
There was a problem hiding this comment.
Hmm, that's a very good point. Let me try that.
There was a problem hiding this comment.
It apparently already is (superset-ui/core):
There was a problem hiding this comment.
Huh, then it's rather strange that it requires resolving
kgabryje
reviewed
Oct 4, 2021
superset-frontend/webpack.config.js
Outdated
| }, | ||
| extensions: ['.ts', '.tsx', '.js', '.jsx', '.yml'], | ||
| symlinks: false, | ||
| symlinks: true, |
There was a problem hiding this comment.
We can remove that line, symlinks: true is the default
villebro
force-pushed
the
villebro/webpack5-npm-link-pt2
branch
from
4c149f2
to
7e36733
Compare
kgabryje
approved these changes
Oct 4, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix(build): make npm linking work pt. 2 * remove explicit symlinks conf
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix(build): make npm linking work pt. 2 * remove explicit symlinks conf
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The recent upgrade to Webpack 5 in #16701 broke npm linking. While #16867 added watching for changed files, it still didn't update the browser with the new assets. This switches from using
watchOptions.followSymlinksto the more conventionalconfig.symlinkssetting, and adds an alias forreactto point to the one pulled in by the Superset application. This is necessary, as otherwise there will be two instances of React - one fro Superset, and one fromsuperset-ui.TESTING INSTRUCTIONS
superset-uipackage/pluginADDITIONAL INFORMATION