style: Update text for SLL Tooltip

[gabester78]

SUMMARY

Changed the SSL tooltip text to a general hint for all users.
https://trello.com/c/B4i4wtpq/29-update-ssl-tooltip-text

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

• From the Welcome screen navigate to Data > Databases
• Click on "+ Database" button
• Hover over SLL Tooltip at the bottom of the form

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[lyndsiWilliams]

Looks good to me!

[codecov]

Codecov Report

Merging #16993 (18db25f) into master (3f6a24f) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16993      +/-   ##
==========================================
- Coverage   76.90%   76.84%   -0.07%     
==========================================
  Files        1024     1026       +2     
  Lines       54931    54915      -16     
  Branches     7486     7478       -8     
==========================================
- Hits        42246    42197      -49     
- Misses      12437    12467      +30     
- Partials      248      251       +3     

Flag	Coverage Δ
javascript	70.89% <ø> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../database/DatabaseModal/DatabaseConnectionForm.tsx	48.71% <ø> (ø)
...rontend/src/components/Select/DeprecatedSelect.tsx	64.70% <0.00%> (-15.69%)	⬇️
superset-frontend/src/components/Select/styles.tsx	70.83% <0.00%> (-13.89%)	⬇️
.../src/explore/components/controls/SelectControl.jsx	78.68% <0.00%> (-10.70%)	⬇️
...ontend/src/dashboard/components/menu/HoverMenu.tsx	90.00% <0.00%> (-10.00%)	⬇️
.../explore/components/controls/TextControl/index.tsx	82.92% <0.00%> (-4.88%)	⬇️
...-frontend/src/dashboard/reducers/dashboardState.js	61.97% <0.00%> (-4.70%)	⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx	83.33% <0.00%> (-3.34%)	⬇️
...nd/src/dashboard/util/activeAllDashboardFilters.ts	89.28% <0.00%> (-3.31%)	⬇️
...uperset-frontend/src/components/Menu/MenuRight.tsx	91.22% <0.00%> (-1.08%)	⬇️
... and 97 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6a24f...18db25f. Read the comment docs.

[geido]

@gabester78 Thanks for the contribution!

I believe the text might be misleading. Our documentation does not always have a reference to the SSL settings, see MySQL for instance. In other cases, such as Presto, you would just be redirected to the database list. I would rather change the text with something even more generic, like:

Enable SSL for increased security. Refer to the official documentation for more information.

[lyndsiWilliams]

@gabester78 Thanks for the contribution!

I believe the text might be misleading. Our documentation does not always have a reference to the SSL settings, see MySQL for instance. In other cases, such as Presto, you would just be redirected to the database list. I would rather change the text with something even more generic, like:

Enable SSL for increased security. Refer to the official documentation for more information.

Hey Geido! This is the text that Sophie requested, but you bring up a good point if we don't have documentation for all database SSL settings. I think this would be better in that case, but I'd like to check and make sure it's alright to change - what do you think @yousoph ?

[yousoph]

Thanks for the suggestion @geido, that's a good point. The text you suggested makes sense to me!

[gabester78]

Changed tooltip text per Geido's suggestion. I was having issues with the setup.cfg file being changed when trying to push up changes so I made the change directly in Github.

[geido]

LGTM!