Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: letter format of sort chart in dashboard edit #17003

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

jinghua-qa
Copy link
Member

@jinghua-qa jinghua-qa commented Oct 7, 2021

SUMMARY

Fix letter format of 'sort chart' in dashboard edit

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image (5)

After:
image (4)

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [dashboard edit] Sort by menu for adding chart need some consistency #16904
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Oct 7, 2021
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #17003 (bcde457) into master (cde4cdc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17003   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files        1030     1030           
  Lines       55031    55031           
  Branches     7465     7465           
=======================================
  Hits        42336    42336           
- Misses      12441    12446    +5     
+ Partials      254      249    -5     
Flag Coverage Δ
javascript 70.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/dashboard/components/SliceAdder.jsx 77.02% <ø> (ø)
superset-frontend/src/views/CRUD/hooks.ts 47.23% <0.00%> (ø)
superset-frontend/src/views/CRUD/utils.tsx 56.48% <0.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 74.35% <0.00%> (ø)
...end/src/visualizations/FilterBox/transformProps.ts 6.66% <0.00%> (ø)
...c/SqlLab/components/RunQueryActionButton/index.tsx 65.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde4cdc...bcde457. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 6dc00b3 into apache:master Oct 7, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@AAfghahi
Copy link
Member

🏷 v1.4

eschutho pushed a commit that referenced this pull request Nov 22, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:QA Preset QA team size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants