Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loading indicator of table and schema selectors #17040

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the loading indicatos in TableSelector.

@serenajiang

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-10-08.at.3.35.45.PM.mov
Screen.Recording.2021-10-08.at.3.33.32.PM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@serenajiang serenajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #17040 (2c3a1d6) into master (e32a12f) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17040      +/-   ##
==========================================
- Coverage   76.70%   76.69%   -0.01%     
==========================================
  Files        1031     1031              
  Lines       55155    55163       +8     
  Branches     7499     7501       +2     
==========================================
+ Hits        42307    42309       +2     
- Misses      12596    12602       +6     
  Partials      252      252              
Flag Coverage Δ
javascript 70.86% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx 91.56% <50.00%> (-3.44%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 75.24% <50.00%> (-2.31%) ⬇️
...c/dashboard/components/gridComponents/Markdown.jsx 83.49% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32a12f...2c3a1d6. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 7c1c89c into apache:master Oct 8, 2021
@sadpandajoe
Copy link
Contributor

🏷️ 2021.40

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Oct 11, 2021
@villebro villebro added the v1.4 label Oct 12, 2021
@eschutho eschutho added v1.4 and removed v1.4 labels Oct 26, 2021
eschutho pushed a commit to preset-io/superset that referenced this pull request Oct 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.40 size/S v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants