chore: add logging on successful data uploads #17065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
force-pushed
the
elizabeth/add-logging
branch
from
203a7ff
to
30ee66d
Compare
eschutho
force-pushed
the
elizabeth/add-logging
branch
from
30ee66d
to
a237e0d
Compare
eschutho
force-pushed
the
elizabeth/add-logging
branch
from
a237e0d
to
510f48e
Compare
eschutho
force-pushed
the
elizabeth/add-logging
branch
from
510f48e
to
5b92678
Compare
eschutho
force-pushed
the
elizabeth/add-logging
branch
from
5b92678
to
17455f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #17065 +/- ##
=======================================
Coverage 76.67% 76.67%
=======================================
Files 1031 1031
Lines 55182 55183 +1
Branches 7505 7505
=======================================
+ Hits 42310 42311 +1
Misses 12620 12620
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 11, 2021
(cherry picked from commit c2e1ab6)
eschutho
added a commit
to preset-io/superset
that referenced
this pull request
Oct 27, 2021
(cherry picked from commit c2e1ab6)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently logging statsd for file uploads (excel/csv/columnar). This PR adds additional logging so that we can get more information about the db being logged to, as well as other information logged per each system such as user information. The statsd is automatically passed to the event_logger, so this shouldn't change or break any existing functionality.
TESTING INSTRUCTIONS
This needs to be tested with the event_logger integration from configs.
ADDITIONAL INFORMATION