Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use official isort in pre-commmit #17215

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

The mirrors-isort is deprecated that 10 months ago. Use official isort repo instead of isort mirror

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #17215 (72c632f) into master (31085e3) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17215   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files        1039     1039           
  Lines       55608    55608           
  Branches     7580     7580           
=======================================
  Hits        42786    42786           
  Misses      12572    12572           
  Partials      250      250           
Flag Coverage Δ
hive 81.47% <50.00%> (ø)
mysql 81.92% <50.00%> (ø)
postgres 81.93% <50.00%> (ø)
presto 81.79% <50.00%> (ø)
python 82.42% <50.00%> (ø)
sqlite 81.60% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.50% <ø> (ø)
superset/sqllab/command.py 85.21% <0.00%> (ø)
superset/sqllab/execution_context_convertor.py 86.95% <0.00%> (ø)
superset/sqllab/query_render.py 88.46% <0.00%> (ø)
superset/security/manager.py 91.84% <66.66%> (ø)
superset/initialization/__init__.py 87.90% <100.00%> (ø)
superset/utils/core.py 90.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31085e3...72c632f. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks for bringing this up to date!

@zhaoyongjie zhaoyongjie merged commit 4f1d202 into apache:master Oct 25, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants