Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes the ChartIcon component #17216

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR removes the ChartIcon component and replaces the code with an icon from our Icons component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-10-25 at 11 30 51 AM

Screen Shot 2021-10-25 at 11 27 16 AM

TESTING INSTRUCTIONS

1 - Open a dashboard
2 - Enter in edit mode
3 - Click on the 3 dots on the right top corner
4 - Click on Set filter mapping
5 - See the changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #17216 (e4112e4) into master (4c96ae7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e4112e4 differs from pull request most recent head 6d6e778. Consider uploading reports for the commit 6d6e778 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17216      +/-   ##
==========================================
- Coverage   76.95%   76.95%   -0.01%     
==========================================
  Files        1038     1037       -1     
  Lines       55597    55594       -3     
  Branches     7585     7583       -2     
==========================================
- Hits        42787    42783       -4     
- Misses      12560    12561       +1     
  Partials      250      250              
Flag Coverage Δ
javascript 71.00% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/filterscope/renderFilterScopeTreeNodes.jsx 87.50% <100.00%> (+0.83%) ⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.13% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c96ae7...6d6e778. Read the comment docs.

@geido
Copy link
Member

geido commented Oct 26, 2021

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://18.236.254.24:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit dd71035 into apache:master Oct 26, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants