Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various typo fixes in MD files #17309

Merged
merged 3 commits into from
Nov 9, 2021
Merged

fix: various typo fixes in MD files #17309

merged 3 commits into from
Nov 9, 2021

Conversation

PApostol
Copy link
Contributor

@PApostol PApostol commented Nov 1, 2021

This PR fixes some typos in the following files: CHANGELOG.md, CONTRIBUTING.md, UPDATING.md, RELEASING/README.md

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@PApostol PApostol changed the title Various typo fixes in MD files fix: various typo fixes in MD files Nov 1, 2021
villebro
villebro requested changes Nov 2, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! The changes to CONTRIBUTING.md, RELEASING.md and UPDATING.md look good, but I would personally prefer the changes to CHANGELOG.md to be removed to make sure they correspond to the original PR titles.

CHANGELOG.md Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S and removed size/L labels Nov 2, 2021
geido
geido reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
@PApostol @geido
Update CONTRIBUTING.md
d8d5223 
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
amitmiran137
amitmiran137 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

villebro
villebro approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements!

@villebro villebro merged commit 6b1de57 into apache:master Nov 9, 2021
@PApostol PApostol deleted the fix-typos-in-md-files branch November 9, 2021 19:41
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@PApostol @geido @AAfghahi
fix: various typo fixes in MD files (#17309)
60f04f1 
* Various typo fixes in MD files

* Undo fixes in CHANGELOG.md to match PR titles

* Update CONTRIBUTING.md

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido left review comments

@villebro villebro villebro approved these changes

@amitmiran137 amitmiran137 amitmiran137 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PApostol @villebro @amitmiran137 @geido @mistercrunch