Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add native filter e2e test part3 #17343

Merged
merged 2 commits into from Nov 5, 2021

Conversation

jinghua-qa
Copy link
Member

SUMMARY

add 2 more e2e test for native filter
1, User can undo deleting a native filter
2, Verify setting options and tooltips for value filter

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Nov 4, 2021
@jinghua-qa jinghua-qa changed the title add 2 stable test test: add native filter e2e test part3 Nov 4, 2021
@jinghua-qa jinghua-qa closed this Nov 4, 2021
@jinghua-qa jinghua-qa reopened this Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #17343 (06d3844) into master (4e9f812) will decrease coverage by 0.21%.
The diff coverage is 80.00%.

❗ Current head 06d3844 differs from pull request most recent head afddb08. Consider uploading reports for the commit afddb08 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17343      +/-   ##
==========================================
- Coverage   77.19%   76.97%   -0.22%     
==========================================
  Files        1036     1036              
  Lines       55686    55696      +10     
  Branches     7627     7627              
==========================================
- Hits        42986    42872     -114     
- Misses      12444    12568     +124     
  Partials      256      256              
Flag Coverage Δ
hive ?
javascript 71.41% <ø> (-0.01%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/post_processing.py 67.21% <80.00%> (+1.14%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.76% <0.00%> (-17.06%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.24% <0.00%> (-1.62%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.13% <0.00%> (-0.59%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.94% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9f812...afddb08. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit ab1fcf3 into apache:master Nov 5, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:QA Preset QA team size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants