Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Check validity of control item #17349

Merged
merged 1 commit into from
Nov 5, 2021
Merged

fix(Dashboard): Check validity of control item #17349

merged 1 commit into from
Nov 5, 2021

Conversation

geido
Copy link
Member

@geido geido commented Nov 5, 2021

SUMMARY

It fixes an unexpected error with invalid control items.

BEFORE

Screen Shot 2021-11-04 at 5 10 50 PM

AFTER

Screen Shot 2021-11-05 at 08 57 23

TESTING INSTRUCTIONS

  1. Open the deck.gl Demo Dashboard
  2. Make sure it loads

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@kgabryje kgabryje changed the title fix(Dashboard) Check validity of control item fix(Dashboard): Check validity of control item Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #17349 (87529cf) into master (e5fe186) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17349   +/-   ##
=======================================
  Coverage   77.13%   77.14%           
=======================================
  Files        1036     1036           
  Lines       55743    55743           
  Branches     7628     7628           
=======================================
+ Hits        43000    43001    +1     
+ Misses      12487    12486    -1     
  Partials      256      256           
Flag Coverage Δ
javascript 71.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/explore/controlUtils/getControlState.ts 88.88% <100.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.71% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5fe186...87529cf. Read the comment docs.

@geido geido merged commit d0085b1 into apache:master Nov 5, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.44

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Nov 5, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@eschutho eschutho added the v1.4 label Jan 12, 2022
eschutho pushed a commit that referenced this pull request Jan 12, 2022
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.44 size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants