fix: Remove horizontal scroll navigation from SQL Lab

[etr2460]

SUMMARY

People commonly complain about accidentally navigating forwards or backwards in chrome when horizontally scrolling in SQL Lab. Most of our app doesn't have such a horizontal scrolling paradigm, but SQL Lab is the exception. So let's remove that horizontal scrolling navigation behavior in SQL Lab

TESTING INSTRUCTIONS

Spin up a testenv and test. make sure you can't horizontal scroll to go forward and backwards in sql lab. But when you go back to a dashboard/explore see that you can

Before:

before.with.scroll.mov

After:

after.no.scroll.mov

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

to: @graceguo-supercat @ktmud @rusackas @michael-s-molina

[etr2460]

Marking as ready for review to get the docker build, will tag people when it's actually ready

[etr2460]

/testenv up

[github-actions]

@etr2460 Ephemeral environment spinning up at http://52.35.144.201:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[codecov]

Codecov Report

Merging #17356 (2625e52) into master (fa51b32) will not change coverage.
The diff coverage is n/a.

❗ Current head 2625e52 differs from pull request most recent head cc98071. Consider uploading reports for the commit cc98071 to get more accurate results

@@           Coverage Diff           @@
##           master   #17356   +/-   ##
=======================================
  Coverage   77.06%   77.06%           
=======================================
  Files        1036     1036           
  Lines       55757    55757           
  Branches     7628     7628           
=======================================
  Hits        42969    42969           
  Misses      12532    12532           
  Partials      256      256           

Flag	Coverage Δ
javascript	71.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa51b32...cc98071. Read the comment docs.

[etr2460]

/testenv down

[etr2460]

/testenv up

[github-actions]

@etr2460 Ephemeral environment spinning up at http://18.236.74.45:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[betodealmeida]

Can we turn it off for the whole app? I hate that pattern! 😆

[etr2460]

Can we turn it off for the whole app? I hate that pattern! 😆

We can consider it, would appreciate a UX designer/PM's take on that first

[ghost]

I'd need to do some research on the accessibility issues around turning it off for the entire app, but big thumbs up to doing it here!

[betodealmeida]

<3

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[ktmud]

@etr2460 @betodealmeida Table chart would need horizontal scrolling at least. Some other tables may also need it.

[betodealmeida]

@etr2460 @betodealmeida Table chart would need horizontal scrolling at least. Some other tables may also need it.

Oh, if I understood correctly we're not getting rid of horizontal scrolling (that's also needed in SQL Lab), but navigating between pages by using horizontal scrolling.