Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Missing dashboardId when refreshing Explore #17380

Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix(Dashboard): Missing dashboardId when refreshing Explore #17380

merged 1 commit into from
Nov 11, 2021

Conversation

geido
Copy link
Member

@geido geido commented Nov 9, 2021

SUMMARY

This PR fixes an issue for which the dashboardId was lost when refreshing Explore.

BEFORE

Fixes #17244

AFTER

DEV.Superset.mp4

TESTING INSTRUCTIONS

  1. Open a Chart in Explore from a Dashboard with custom label colors
  2. Refresh Explore
  3. Make sure the custom label colors are not lost

ADDITIONAL INFORMATION

  • Has associated issue: [Explore] The dashboard ID will be lost when refreshing the page #17244
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido changed the title Fix missing dashboardId fix(Dashboard): Missing dashboardId when refreshing Explore Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #17380 (f4bbee5) into master (561d1ac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17380      +/-   ##
==========================================
- Coverage   77.07%   77.06%   -0.01%     
==========================================
  Files        1036     1036              
  Lines       55756    55759       +3     
  Branches     7630     7633       +3     
==========================================
  Hits        42972    42972              
- Misses      12529    12532       +3     
  Partials      255      255              
Flag Coverage Δ
javascript 71.42% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 2.08% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561d1ac...f4bbee5. Read the comment docs.

@geido
Copy link
Member Author

geido commented Nov 9, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

@geido Ephemeral environment spinning up at http://35.86.162.87:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 7cdd58b into apache:master Nov 11, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
Color consistency
Awaiting triage
Development

Successfully merging this pull request may close these issues.

[Explore] The dashboard ID will be lost when refreshing the page
4 participants