Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reorder install instructions in CONTRIBUTING.md #17387

Merged
merged 1 commit into from Nov 10, 2021

Conversation

willbarrett
Copy link
Member

@willbarrett willbarrett commented Nov 10, 2021

SUMMARY

The install documentation recommended creating an admin user before setting up the database. This PR reorders the install instructions so that the database structure is created before attempting to create an admin user.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@willbarrett
Copy link
Member Author

Pinging @dpgaspar for a review because it's a little bit FAB-related, and I miss his face.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #17387 (ea5c576) into master (7d22c9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17387   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files        1038     1038           
  Lines       56013    56013           
  Branches     7735     7735           
=======================================
  Hits        43142    43142           
  Misses      12613    12613           
  Partials      258      258           
Flag Coverage Δ
hive 81.48% <ø> (ø)
javascript 71.22% <ø> (ø)
mysql 81.90% <ø> (ø)
postgres 81.91% <ø> (ø)
presto 81.78% <ø> (ø)
python 82.41% <ø> (ø)
sqlite 81.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d22c9c...ea5c576. Read the comment docs.

@srinify
Copy link
Contributor

srinify commented Nov 10, 2021

I'll approve this :) I spent a bunch of time recently with the first "one minute" of setting up superset and this change makes sense. Thanks Will!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement!

@dpgaspar
Copy link
Member

Great to "see" you here @willbarrett! this makes perfect sense.

@dpgaspar dpgaspar merged commit 8f9cea8 into master Nov 10, 2021
jinghua-qa pushed a commit to jinghua-qa/superset that referenced this pull request Nov 10, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the wbarrett/reorder-install-instructions branch March 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants