Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump major on Pillow, optional dependency #17521

Merged
merged 4 commits into from
Nov 23, 2021
Merged

chore: bump major on Pillow, optional dependency #17521

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c8f50b
chore: bump major on Pillow, optional dependency
dpgaspar Nov 23, 2021
ce640ac
bump to 8.3.2
dpgaspar Nov 23, 2021
8dc2798
Revert "bump to 8.3.2"
dpgaspar Nov 23, 2021
721948e
bump to 8.3.2 now the right way
dpgaspar Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def get_git_sha() -> str:
"snowflake-sqlalchemy==1.2.4"
], # PINNED! 1.2.5 introduced breaking changes requiring sqlalchemy>=1.4.0
"teradata": ["sqlalchemy-teradata==0.9.0.dev0"],
"thumbnails": ["Pillow>=7.0.0, <8.0.0"],
"thumbnails": ["Pillow>=8.2.0, <9.0.0"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we're already pinning to >=8.3.1 in the development deps - perhaps we could use the same version here and potentially consider bumping to 8.3.2 which addresses CVE-2021-23437?

superset/requirements/development.in

Line 21 in 0f3b630

pillow>=8.3.1,<9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, made the change

"vertica": ["sqlalchemy-vertica-python>=0.5.9, < 0.6"],
"netezza": ["nzalchemy>=11.0.2"],
},
Expand Down