Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: temporarily enable merge in .asf.yml #17560

Merged
merged 1 commit into from
Nov 26, 2021
Merged

chore: temporarily enable merge in .asf.yml #17560

merged 1 commit into from
Nov 26, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Nov 26, 2021 •
edited by villebro

SUMMARY

temporarily enable merge from PR to master branch to make it possible to retain the full commit history of superset-ui repo in #17445

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

villebro
villebro approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie mentioned this pull request Nov 26, 2021
Merged
9 tasks
@zhaoyongjie zhaoyongjie merged commit 19ffba1 into apache:master Nov 26, 2021
@villebro villebro mentioned this pull request Nov 26, 2021
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
cccs-RyanK pushed a commit to CybercentreCanada/superset that referenced this pull request Jun 4, 2024
@zhaoyongjie @cccs-RyanK
chore: temporarily enable merge in .asf.yml (apache#17560)
e9e60f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhaoyongjie @villebro @mistercrunch