Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add missing fields to dataset schemas #17620

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 1, 2021

SUMMARY

The dataset metric PUT schema is missing a few key fields, namely extra, verbose_name and uuid. In addition, the fields extra and uuid on the column schema have incorrect types, causing schema validation errors. This PR fixes the errors and adds relevant tests that would fail on master. Closes #17390.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #17620 (8c9a2b4) into master (d7e3a60) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17620      +/-   ##
==========================================
- Coverage   68.59%   68.36%   -0.23%     
==========================================
  Files        1588     1601      +13     
  Lines       64948    65263     +315     
  Branches     6963     6963              
==========================================
+ Hits        44548    44619      +71     
- Misses      18510    18754     +244     
  Partials     1890     1890              
Flag Coverage Δ
hive ?
mysql 81.80% <100.00%> (-0.23%) ⬇️
postgres 81.81% <100.00%> (-0.23%) ⬇️
presto ?
python 81.89% <100.00%> (-0.64%) ⬇️
sqlite 81.49% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/schemas.py 96.61% <100.00%> (+0.08%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/utils/cache_manager.py 96.15% <0.00%> (-3.85%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.15% <0.00%> (-0.39%) ⬇️
superset/dashboards/api.py 91.86% <0.00%> (-0.29%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e3a60...8c9a2b4. Read the comment docs.

@villebro villebro merged commit 0544bee into apache:master Dec 1, 2021
@villebro villebro deleted the villebro/fix-ds-schemas branch December 2, 2021 06:32
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to update dataset metric's label via the rest PUT api
4 participants