Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting [ID-29] #17634

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 2, 2021

SUMMARY

This PR adds more descriptive tooltips to Sort by rows and Sort by columns controls in Pivot Table V2 chart. The goal is to avoid confusion on how each sorting mode works and what values are used as sorting keys.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

image

TESTING INSTRUCTIONS

Check tooltips grammar.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje changed the title chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting [ID-29] Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #17634 (540e098) into master (a3cce57) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 540e098 differs from pull request most recent head f7d1b81. Consider uploading reports for the commit f7d1b81 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17634      +/-   ##
==========================================
- Coverage   68.57%   68.37%   -0.21%     
==========================================
  Files        1602     1602              
  Lines       65349    65351       +2     
  Branches     6992     6992              
==========================================
- Hits        44816    44684     -132     
- Misses      18647    18785     +138     
+ Partials     1886     1882       -4     
Flag Coverage Δ
hive ?
javascript 57.11% <100.00%> (-0.04%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugin-chart-pivot-table/src/plugin/controlPanel.tsx 46.15% <100.00%> (ø)
...src/components/FilterableTable/FilterableTable.tsx 66.85% <100.00%> (-7.29%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.15% <0.00%> (-0.39%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cce57...f7d1b81. Read the comment docs.

@kgabryje
Copy link
Member Author

kgabryje commented Dec 2, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

@kgabryje Ephemeral environment spinning up at http://54.244.15.102:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar nits noted as requested. LOVE this improvement!

kgabryje and others added 2 commits December 2, 2021 18:56
…controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>
…controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit e8ce873 into apache:master Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants