Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update babel doc #17679

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Dec 8, 2021

SUMMARY

In order to make .pot file and .po files to stay consistency.

  1. add pybabel update in babel_update.sh
  2. update contributing.md
  3. update all .po files
  4. update translation workflow

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #17679 (342f891) into master (3350076) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17679   +/-   ##
=======================================
  Coverage   68.85%   68.85%           
=======================================
  Files        1598     1598           
  Lines       65248    65248           
  Branches     6950     6950           
=======================================
  Hits        44929    44929           
  Misses      18434    18434           
  Partials     1885     1885           
Flag Coverage Δ
hive 81.70% <ø> (ø)
mysql 82.11% <ø> (ø)
postgres 82.12% <ø> (ø)
python 82.46% <ø> (ø)
sqlite 81.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3350076...342f891. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zhaoyongjie zhaoyongjie merged commit 12f1d91 into apache:master Dec 8, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants