Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Undefined error in default value in Native Filters #17692

Merged
merged 1 commit into from Dec 8, 2021
Merged

fix(Dashboard): Undefined error in default value in Native Filters #17692

merged 1 commit into from Dec 8, 2021

Conversation

geido
Copy link
Member

@geido geido commented Dec 8, 2021

SUMMARY

Fixes an undefined error generated by the DefaultValue component in the Native Filters.

BEFORE

default.value.mov

AFTER

World.Bank.s.Data.mp4

NOTE

In the video, a new bug is shown. By typing the country name, the previous countries will be discarded. This requires a separate fix.

TESTING INSTRUCTIONS

  1. Open a Dashboard
  2. Create a filter of type Value
  3. Enter a default value
  4. Observe the behavior

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #17692 (98ab935) into master (8c25f2f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17692   +/-   ##
=======================================
  Coverage   68.86%   68.86%           
=======================================
  Files        1598     1598           
  Lines       65297    65297           
  Branches     6952     6952           
=======================================
  Hits        44966    44966           
  Misses      18446    18446           
  Partials     1885     1885           
Flag Coverage Δ
javascript 57.46% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 27.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c25f2f...98ab935. Read the comment docs.

@rusackas rusackas merged commit aad2abe into apache:master Dec 8, 2021
@jinghua-qa
Copy link
Member

🏷️ 2021.49

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 10, 2021
(cherry picked from commit aad2abe)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.49 size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants