Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add __init__.py to key_value #17730

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Dec 13, 2021

SUMMARY

Adds init.py file

error log:

state/commands/create.py", line 24, in <module>
    from superset.key_value.commands.create import CreateKeyValueCommand
ModuleNotFoundError: No module named 'superset.key_value'

TESTING INSTRUCTIONS

N/A

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #17730 (92c8f45) into master (63d9693) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 92c8f45 differs from pull request most recent head 3db9e0a. Consider uploading reports for the commit 3db9e0a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17730      +/-   ##
==========================================
- Coverage   67.70%   67.65%   -0.05%     
==========================================
  Files        1602     1602              
  Lines       64151    64146       -5     
  Branches     6773     6773              
==========================================
- Hits        43434    43401      -33     
- Misses      18864    18892      +28     
  Partials     1853     1853              
Flag Coverage Δ
hive ?
mysql 82.15% <100.00%> (?)
postgres ?
presto 82.07% <100.00%> (?)
python 82.41% <100.00%> (-0.10%) ⬇️
sqlite 81.88% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/filter_state/commands/get.py 86.66% <100.00%> (ø)
superset/key_value/commands/get.py 85.71% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 89.13% <0.00%> (-2.18%) ⬇️
superset/db_engine_specs/postgres.py 96.36% <0.00%> (-0.91%) ⬇️
superset/common/query_object.py 95.08% <0.00%> (-0.55%) ⬇️
superset/views/base_api.py 97.89% <0.00%> (-0.43%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d9693...3db9e0a. Read the comment docs.

@bkyryliuk bkyryliuk requested a review from a team December 13, 2021 19:13
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkyryliuk bkyryliuk merged commit ec24256 into apache:master Dec 15, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* Add __init__.py

* Lisence

* Linter

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* Add __init__.py

* Lisence

* Linter

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants