other: Add Helm chart option for configOverrides through file #17811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to bump your chart version manually |
|
btw using superset_config.py as a Secret object is bad practice. |
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…17811) * Add option to provide configOverrides through file * Bump chart to 0.5.1
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…17811) * Add option to provide configOverrides through file * Bump chart to 0.5.1
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
To extend
superset_config.py, the Superset Helm chart currently allows users to add code underconfigOverridesinvalues.yaml. However, it would be better if this code was in a separate.pyfile in the chart directory. This PR enables that through a similar setup.TESTING INSTRUCTIONS
Create a
test.pyinhelm/supersetand addtest: test.pyas an entry underconfigOverridesFiles. Install withAfter installing,
should show the code in test.py