Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve tests for 1.4 #17835

Merged
merged 1 commit into from
Dec 22, 2021
Merged

fix: resolve tests for 1.4 #17835

merged 1 commit into from
Dec 22, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Dec 21, 2021

SUMMARY

Fixes tests and CI for the 1.4 branch.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho requested a review from a team as a code owner December 21, 2021 00:35
@eschutho eschutho changed the title Elizabeth/test1.4 fix: resolve tests for 1.4 Dec 21, 2021
@eschutho eschutho force-pushed the elizabeth/test1.4 branch 2 times, most recently from 220f527 to 0c15192 Compare December 21, 2021 01:34
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #17835 (bee0ec7) into 1.4 (40b8cc1) will increase coverage by 5.27%.
The diff coverage is 75.60%.

❗ Current head bee0ec7 differs from pull request most recent head 56f3142. Consider uploading reports for the commit 56f3142 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.4   #17835      +/-   ##
==========================================
+ Coverage   76.92%   82.20%   +5.27%     
==========================================
  Files        1030      359     -671     
  Lines       55185    29009   -26176     
  Branches     7497        0    -7497     
==========================================
- Hits        42452    23847   -18605     
+ Misses      12476     5162    -7314     
+ Partials      257        0     -257     
Flag Coverage Δ
hive ?
javascript ?
mysql 81.92% <75.60%> (-0.02%) ⬇️
postgres 81.94% <75.60%> (-0.02%) ⬇️
presto 81.80% <75.60%> (-0.02%) ⬇️
python 82.20% <75.60%> (-0.25%) ⬇️
sqlite 81.60% <75.60%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.44% <ø> (-0.03%) ⬇️
superset/db_engine_specs/ascend.py 100.00% <ø> (ø)
superset/db_engine_specs/athena.py 89.28% <ø> (ø)
superset/db_engine_specs/base.py 88.56% <ø> (ø)
superset/db_engine_specs/bigquery.py 85.97% <ø> (ø)
superset/db_engine_specs/clickhouse.py 66.03% <ø> (ø)
superset/db_engine_specs/crate.py 92.30% <ø> (ø)
superset/db_engine_specs/db2.py 91.66% <ø> (ø)
superset/db_engine_specs/dremio.py 90.00% <ø> (ø)
superset/db_engine_specs/druid.py 86.27% <ø> (ø)
... and 740 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8057582...56f3142. Read the comment docs.

@github-actions
Copy link
Contributor

⚠️ @eschutho Your base branch 1.4 has just also updated superset/migrations.

Please consider rebasing your branch to avoid db migration conflicts.

@eschutho eschutho force-pushed the elizabeth/test1.4 branch 3 times, most recently from d036cc4 to e355319 Compare December 21, 2021 22:25
@eschutho eschutho merged commit 96c18b4 into 1.4 Dec 22, 2021
@eschutho eschutho deleted the elizabeth/test1.4 branch December 22, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant