-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-core): implement drilldown #17883
Conversation
Super excited about this feature, any chance we can it in the next release? |
Codecov Report
@@ Coverage Diff @@
## master #17883 +/- ##
==========================================
- Coverage 67.17% 67.03% -0.14%
==========================================
Files 1609 1612 +3
Lines 64796 64978 +182
Branches 6855 6888 +33
==========================================
+ Hits 43528 43561 +33
- Misses 19412 19543 +131
- Partials 1856 1874 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
As excited as I am about this feature, I think we need to do SIP for this to ensure that we don't end up painting ourselves into a corner by making changes that will become difficult to maintain going forward. For context, the original POC was met with some concern in offline discussions, primarily around what additional changes we would need to introduce to make drill down/drill through functionality in a future proof way without adding technical debt. @EvilDrW would you be open to spearheading a SIP to kickstart the discussion for adding drilldown functionality to Superset? This way we could have a transparent discussion where all parties could be heard, and could also make sure this feature could be rolled out incrementally with a clear implementation plan. |
@EvilDrW I am trying to implement this for the purpose of POC. How can I add this to other types of charts as well, apart from pie chart and bar chart? Also, I see I can add multiple group-by to pie chart and use this drill down feature, but how will this be visible in bar charts? |
hi everyone! |
@EvilDrW is this code available in the latest master branch? if yes then how can i enable this, if not then can you please guide me to implement this in the current latest master branch, so that i can use this feature for now? |
Did you find any answer..? |
Does anyone tried this drilldown on table chart. If yes, Can you please explain me. |
Drill By (flexible exploration) is Superset's preferred solution over Drill Down (strict hierarchy). It's available in Preset and OSS Superset: https://preset.io/blog/drill-by/ |
@EvilDrW |
Add hierarchical traversability to pie charts and bar charts.
SUMMARY
This is an attempt at bringing #14688 and apache-superset/superset-ui#1120 up-to-date with the latest Superset mono repo and extending the feature to work both with echarts/pie and nvd3/distbar.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See video on #14688
TESTING INSTRUCTIONS
Create either a bar chart or pie chart. In the chart editor, select "ENABLE DRILL DOWN." Add multiple columns to the "GROUP BY" field that have a natural hierarchy to them and ensure the order of columns listed reflects the intended hierarchy. Add an appropriate metric (usually COUNT(id) or similar). Observe that only the first column in the hierarchy is reflected in the rendered chart. Observe that clicking one field in the chart adds the selected field to the applied filters and that the second column in the "GROUP BY" hierarchy is now displayed. Observe that selecting a field when the chart is at its deepest level in the hierarchy clears all selected filters and returns the chart to the original state. Observe that saving the chart and adding it to a dashboard results in identical functionality as described above.
ADDITIONAL INFORMATION