chore: bump typescript to 4.5.4, and adjust storybook story. #17971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17971 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 1611 1611
Lines 64919 64919
Branches 6871 6871
=======================================
Hits 43548 43548
Misses 19504 19504
Partials 1867 1867
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
etr2460
approved these changes
Jan 8, 2022
rusackas
force-pushed
the
updating-typescript-to-4.5.4
branch
from
4618e53
to
18c901a
Compare
rusackas
force-pushed
the
updating-typescript-to-4.5.4
branch
from
18c901a
to
9d5dbcb
Compare
|
Thanks for the review @etr2460 - that package lock was accidental, and I'm glad you stopped to notice the gigantic file. |
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…17971) * chore: bump typescript to 4.5.4, and adjust storybook story to pass linting * ugh... missed a space. Thanks, linter :) * nixing erroneous package lock file
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…17971) * chore: bump typescript to 4.5.4, and adjust storybook story to pass linting * ugh... missed a space. Thanks, linter :) * nixing erroneous package lock file
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Saw that This PR was failing due to some esoteric linting issue in a storybook issue. This makes the same bump, also bumps Superset, and fixes the Story.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Verified Storybook works fine locally. CI passing should cover the rest.
ADDITIONAL INFORMATION