chore: reenable lint for test files #17979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
force-pushed
the
reenable_lint
branch
from
bac4944
to
0512e94
Compare
Codecov Report
@@ Coverage Diff @@
## master #17979 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 1611 1611
Lines 64919 64929 +10
Branches 6871 6872 +1
=======================================
+ Hits 43548 43556 +8
- Misses 19504 19506 +2
Partials 1867 1867
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Jan 11, 2022
| @@ -180,17 +181,6 @@ module.exports = { | |||
| ], | |||
| 'no-only-tests/no-only-tests': 'error', | |||
| 'max-classes-per-file': 0, | |||
| '@typescript-eslint/no-non-null-assertion': 0, | |||
| // TODO: disabled temporarily, re-enable after monorepo | |||
rusackas
approved these changes
Jan 11, 2022
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* chore: reenable lint for test files * fix comments
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* chore: reenable lint for test files * fix comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
reenable lint for test files
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION