Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude node_modules from ts tracking #18117

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: exclude node_modules from ts tracking #18117

merged 1 commit into from
Jan 25, 2022

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jan 20, 2022

SUMMARY

This script didn't work as expected now that we have packages inside the superset monorepo. We don't need to track TS usage in deps, so filter out the node_modules directory

TESTING INSTRUCTIONS

Run the script

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @betodealmeida @ktmud @graceguo-supercat

betodealmeida
betodealmeida approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@etr2460 etr2460 merged commit 9900e5a into apache:master Jan 25, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@shcoderAlex
fix: exclude node_modules from ts tracking (apache#18117)
7a94964
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
@ofekisr
fix: exclude node_modules from ts tracking (apache#18117)
ee1e5b4
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@bwang221
fix: exclude node_modules from ts tracking (apache#18117)
10163e9
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etr2460 @betodealmeida @mistercrunch