Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant propTypes in ColumnElement #18144

Merged
merged 3 commits into from
Feb 7, 2022
Merged

refactor: remove redundant propTypes in ColumnElement #18144

merged 3 commits into from
Feb 7, 2022

Conversation

EugeneTorap
Copy link
Contributor

@EugeneTorap EugeneTorap commented Jan 23, 2022

SUMMARY

Refactoring ColumnElement component and remove redundant propTypes code

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #18144 (7576bb2) into master (0cec0c9) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18144      +/-   ##
==========================================
- Coverage   65.95%   65.92%   -0.03%     
==========================================
  Files        1584     1587       +3     
  Lines       62046    62116      +70     
  Branches     6273     6287      +14     
==========================================
+ Hits        40920    40950      +30     
- Misses      19505    19544      +39     
- Partials     1621     1622       +1     
Flag Coverage Δ
javascript 50.86% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/ColumnElement/index.tsx 93.33% <100.00%> (-0.42%) ⬇️
...rc/explore/components/controls/TextAreaControl.jsx 80.00% <0.00%> (-4.22%) ⬇️
...nd/src/explore/components/ExploreActionButtons.tsx 59.45% <0.00%> (-3.40%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 58.97% <0.00%> (-1.56%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 68.42% <0.00%> (-0.60%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 62.65% <0.00%> (-0.32%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.46% <0.00%> (-0.22%) ⬇️
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
superset-frontend/src/setup/setupClient.ts 0.00% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cec0c9...7576bb2. Read the comment docs.

@geido
Copy link
Member

geido commented Jan 25, 2022

Just started the CI. I'll keep an eye

@EugeneTorap
Copy link
Contributor Author

Just started the CI. I'll keep an eye

Can also test 18141, 18142, 18143 PR?

@EugeneTorap
Copy link
Contributor Author

@lyndsiWilliams @AAfghahi Can you merge the PR?

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got just one question, otherwise this looks good 😁

@lyndsiWilliams
Copy link
Member

@lyndsiWilliams @AAfghahi Can you merge the PR?

We can review and approve PRs, but we can't merge unless there's also an approval from a higher-level engineer.

@EugeneTorap
Copy link
Contributor Author

@lyndsiWilliams @AAfghahi Can you merge the PR?

We can review and approve PRs, but we can't merge unless there's also an approval from a higher-level engineer.

@lyndsiWilliams Got it, can you review it again?

@lyndsiWilliams
Copy link
Member

@lyndsiWilliams @AAfghahi Can you merge the PR?

We can review and approve PRs, but we can't merge unless there's also an approval from a higher-level engineer.

@lyndsiWilliams Got it, can you review it again?

The code looks good! Could you fill in the description of your PR?

@EugeneTorap
Copy link
Contributor Author

@lyndsiWilliams @AAfghahi Can you merge the PR?

We can review and approve PRs, but we can't merge unless there's also an approval from a higher-level engineer.

@lyndsiWilliams Got it, can you review it again?

The code looks good! Could you fill in the description of your PR?

Sure, done

@srinify srinify merged commit 85c8d01 into apache:master Feb 7, 2022
@EugeneTorap EugeneTorap deleted the refactoring-ColumnElement branch February 7, 2022 18:31
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
* Remove redundant propTypes

* Refactoring

* Refactoring
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants