Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default values getting cleared in native filters form #18180

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix: Default values getting cleared in native filters form #18180

merged 1 commit into from
Jan 27, 2022

Conversation

geido
Copy link
Member

@geido geido commented Jan 26, 2022

SUMMARY

Fixes #18149

This PR fixes an issue for which existing default values were cleared after searching. It should also reduce the number of renders as the state was triggered unnecessarily.

BEFORE

Unicode.Test.mp4

AFTER

Unicode.Test.2.mp4

TESTING INSTRUCTIONS

  1. Open a Dashboard
  2. Set default values in native filters
  3. Try to search for a new value
  4. Make sure the previously selected values do not disappear

ADDITIONAL INFORMATION

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #18180 (223bbaa) into master (4ad5ad0) will increase coverage by 0.00%.
The diff coverage is 92.30%.

❗ Current head 223bbaa differs from pull request most recent head 83db568. Consider uploading reports for the commit 83db568 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18180   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files        1591     1591           
  Lines       62398    62409   +11     
  Branches     6283     6283           
=======================================
+ Hits        41210    41221   +11     
  Misses      19567    19567           
  Partials     1621     1621           
Flag Coverage Δ
javascript 50.85% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 79.62% <50.00%> (ø)
superset/reports/notifications/email.py 100.00% <100.00%> (ø)
superset/utils/urls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad5ad0...83db568. Read the comment docs.

@rusackas rusackas removed the Flexiana label Jan 26, 2022
@geido geido merged commit a4e93af into apache:master Jan 27, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard] [native filters] Existing default values get deleted when searching
4 participants