refactor: upgrade ControlHeader to TSX & FC and add storybook #18188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18188 +/- ##
=======================================
Coverage 66.04% 66.04%
=======================================
Files 1591 1591
Lines 62415 62421 +6
Branches 6285 6289 +4
=======================================
+ Hits 41224 41229 +5
- Misses 19569 19570 +1
Partials 1622 1622
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
reviewed
Jan 27, 2022
superset-frontend/src/explore/components/ControlHeader.stories.tsx
Outdated
Show resolved
Hide resolved
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://34.215.33.208:8080. Credentials are |
etr2460
approved these changes
Jan 27, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…#18188) * refactor: upgrade ControlHeader to TSX & FC and add storybook * fix: Add story for error in ControlHeader * apply review comments
ofekisr
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 8, 2022
…#18188) * refactor: upgrade ControlHeader to TSX & FC and add storybook * fix: Add story for error in ControlHeader * apply review comments
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…#18188) * refactor: upgrade ControlHeader to TSX & FC and add storybook * fix: Add story for error in ControlHeader * apply review comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Upgraded ControlHeader to TypeScript to apply direction outlined in #18100 .
Added storybook to visualize that component.
Upgraded to FC.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Storybook can be used to verify those changes.
ADDITIONAL INFORMATION
@kgabryje , @mik-laj You might be interested in this PR!