Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x #18204

Closed
wants to merge 1 commit into from

Conversation

rusackas
Copy link
Member

SUMMARY

Attempting to resolve #18129 by bumping the Echarts package to 0.18.22.

Note that master has moved on to monorepo since that release was cut, so this is a little wierd

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@@ -92,7 +92,7 @@
"@superset-ui/legacy-preset-chart-big-number": "^0.18.19",
"@superset-ui/legacy-preset-chart-deckgl": "^0.4.13",
"@superset-ui/legacy-preset-chart-nvd3": "^0.18.19",
"@superset-ui/plugin-chart-echarts": "^0.18.19",
"@superset-ui/plugin-chart-echarts": "^0.18.22",
Copy link
Member

@villebro villebro Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we can do a surgical bump of @superset-ui/plugin-chart-echarts from 0.18.19 to 0.18.22 without also bumping all other @superset-ui packages, as it will cause two different versions of @superset-ui/core to be installed. The only viable option I can think of is to pull in the following superset-ui bumps that will end up bringing in that missing cherry:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superset-ui/plugin-chart-echarts depends on superset-ui/core 0.18.22 https://github.com/apache-superset/superset-ui/blob/v0.18.22/plugins/plugin-chart-echarts/package.json

Can we release a post-monorepo release to resolve this issue?

@rusackas rusackas closed this Feb 4, 2022
@rusackas rusackas deleted the 1.4.x/bumping-echarts branch January 30, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants