fix(plugin-chart-echarts): fix forecasts on verbose metrics

[villebro]

SUMMARY

This fixes a bug in the ECharts timeseries chart, where using a metric with a verbose name caused the forecast and observations to be on separate series (one with the verbose name, and the other with the raw name). A test is also added that ensures verbose names are correctly handled going forward. In addition, all references to "prophet" are replaced with "forecast" in preparation for decoupling the forecasting functionality from Prophet.

AFTER

Now the metric with a verbose name displays correctly in both the chart and the tooltip:

The forecast section is also split up into one control per line:

BEFORE

Previously, the predictions would show up as different series with their non-verbose name, both on the chart and the tooltip

Before, the forecast section headers wrapping caused the controls to be misaligned:

TESTING INSTRUCTIONS

1. Create a v2 Line chart
2. Add the built-in COUNT(*) metric as your primary metric
3. Enable the forecast

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[kgabryje]

The fix doesn't seem to be working well with GENERIC_CHART_AXES ff disabled - Y axis is scaled to timestamp epoch values

[villebro]

The fix doesn't seem to be working well with GENERIC_CHART_AXES ff disabled - Y axis is scaled to timestamp epoch values

Great catch! It turns out datasource.verboseMap always includes an entry { __timestamp: 'Time' } which threw the util function off when it was made more generic. I added added a check for it + added a test for making sure the alias stays unchanged (this logic will be removed once we remove the legacy non-generic timeseries functionality).

[kgabryje]

Retested, works perfectly with and without GENERIC_CHART_AXES!

[codecov]

Codecov Report

Merging #18252 (2a4dde5) into master (8c37654) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master   #18252   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1592     1592           
  Lines       62569    62569           
  Branches     6295     6295           
=======================================
+ Hits        41500    41501    +1     
  Misses      19416    19416           
+ Partials     1653     1652    -1     

Flag	Coverage Δ
javascript	51.38% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...i-chart-controls/src/sections/forecastInterval.tsx	100.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts	0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts	50.83% <ø> (ø)
...frontend/plugins/plugin-chart-echarts/src/types.ts	100.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts	58.06% <14.28%> (ø)
...plugins/plugin-chart-echarts/src/utils/forecast.ts	94.82% <93.33%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c37654...2a4dde5. Read the comment docs.