Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sqllab schema select error msg #18564

Merged
merged 3 commits into from
Feb 4, 2022
Merged

fix: sqllab schema select error msg #18564

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddfd845
fix: sqllab schema select error msg
pkdotson Feb 3, 2022
51a1f7d
remove console logs
pkdotson Feb 3, 2022
7c84de3
fix lint
pkdotson Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions superset-frontend/src/SqlLab/actions/sqlLab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,12 +776,14 @@ export function queryEditorSetDb(queryEditor, dbId) {

export function queryEditorSetSchema(queryEditor, schema) {
return function (dispatch) {
const sync = isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE)
? SupersetClient.put({
endpoint: encodeURI(`/tabstateview/${queryEditor.id}`),
postPayload: { schema },
})
: Promise.resolve();
const sync =
isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE) &&
typeof queryEditor === 'object'
? SupersetClient.put({
endpoint: encodeURI(`/tabstateview/${queryEditor.id}`),
postPayload: { schema },
})
: Promise.resolve();

return sync
.then(() =>
Expand Down