Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Docusaurus links #18581

Merged
merged 4 commits into from
Feb 10, 2022
Merged

chore: Update Docusaurus links #18581

merged 4 commits into from
Feb 10, 2022

Conversation

geido
Copy link
Member

@geido geido commented Feb 4, 2022

SUMMARY

This PR fixes Docusaurus links and removes any whitespace by replacing them with hyphens. It also fixes redirection links so that it keeps older doc links reachable.

TESTING INSTRUCTIONS

  1. Make sure links work correctly and older doc links can be reached

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ad-m
Copy link
Contributor

ad-m commented Feb 5, 2022

I would like to preview that changes. Can we adapt test env for preview docs too?

srinify
srinify approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@srinify srinify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested routes, looks good!

villebro
villebro approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 9ca55a7 into apache:master Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinify srinify srinify approved these changes

@hughhhh hughhhh hughhhh approved these changes

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@geido @ad-m @srinify @hughhhh @villebro @mistercrunch