Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Fix support for ingress.ingressClassName #18619

Merged
merged 1 commit into from Feb 8, 2022

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Feb 8, 2022

SUMMARY

In #18617 @joatkh reported removed support for ingress.ingressClassName in values.yaml of our Chart. It is an undocumented parameter but supported by our Chart:

{{- if .Values.ingress.ingressClassName }}
ingressClassName: {{ .Values.ingress.ingressClassName }}
{{- end }}

That PR re-add that support.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Use ingress.ingressClassName eg. via --set during installation. It should pass validation.

ADDITIONAL INFORMATION

@joatkh could you give a shoot to test if it's working for you?
@craig-rueda could you take a look as maintainer of Chart?

@craig-rueda craig-rueda merged commit 11d71d6 into apache:master Feb 8, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants